Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.2 #2203

Merged
merged 13 commits into from
Feb 8, 2017
Merged

Release 1.2 #2203

merged 13 commits into from
Feb 8, 2017

Conversation

2opremio
Copy link
Contributor

@2opremio 2opremio commented Feb 7, 2017 •
edited by davkal
Loading

@davkal @foot @ekimekim @bowenli @jpellizzari @tomwilkie @abuehrle @pidster @errordeveloper @rade Please chip in by testing this release branch in the scenarios below and tick off what you tested afterwards (including your name at the end). Have a look at the CHANGELOG to prioritize your testing.

To make things easier to test I have pushed the image weaveworks/scope:release-1.2-9e33e7e
Thanks!

  • Start a 2 node cluster and leave a UI connected, watch for performance regression
  • Run a Scope cluster on ECS (mike)
  • Run Scope on https://github.com/microservices-demo/microservices-demo/ (mike)
  • Run Scope on Docker For Mac (Stuart)
  • Start and stop Scope in standalone mode
    • Linux (mike)
    • docker-machine
  • Connect probes from release candidate to Weave Cloud (fons)
    • Local scope in probe-only mode connects to Weave Cloud and renders correctly
      • dev
      • prod
    • Controls appear for containers and function correctly
      • dev
      • prod
    • No new errors in logging or telemetry
      • dev
      • prod
  • UI integration
    • Hot-reloading cd client && npm i && npm start and open http://localhost:4042
    • UI under prefix path cd client && npm run build && npm start-production and open http://localhost:4043/scoped/
    • URL parameters: Run previous release and click around, keep UI open, start new release, reload page
  • UI features
    (To test: clone microservices demo and run cd deploy/docker-compose && docker-compose up)
    • General: switch between topologies, see nodes and edges, details panel (Stuart)
    • Zoom and pan, switch between topologies
    • Topology filters: namespaces, system containers, etc. (Stuart)
    • Metrics on canvas, try pinning/unpinning (Stuart)
    • Search
      • by container name
      • by usage cpu < 2%
    • Terminal (fons)
      • Attach to container to see logs
      • Exec to container and type ls
      • Pop out terminal
    • Contrast mode (fons)
    • Download report
    • Pause button

Things to think about

  • ECS Integration
  • Kubernetes Integration
  • CPU and memory usage

@2opremio
Copy link
Contributor Author

2opremio commented Feb 8, 2017 •
edited
Loading

@simon found #2207, #2208 and #2209. I think #2207 and #2209 should be fixed before the release.

This was referenced Feb 8, 2017
Closed
Closed
@2opremio
Copy link
Contributor Author

2opremio commented Feb 8, 2017 •
edited
Loading

I updated the probes in WeaveCloud dev to run weaveworks/scope:release-1.2-9e33e7e and I don't see any regressions in CPU performance.

It's not great (50% CPU) but better than 1.0 (#1985 (comment) )

probe

@abuehrle
Copy link
Contributor

abuehrle commented Feb 8, 2017

I am just upgrading my environment with scope: scope:release-1.2-9e33e7e

Note also that there was an issue with Zipkin (tracer for microservices demo) hogging a fair share of resources as well: microservices-demo/microservices-demo#598

@2opremio
Copy link
Contributor Author

2opremio commented Feb 8, 2017 •
edited
Loading

Fixes #2216 (doing it here since there is no better way to test it than during a release itself)

foot and others added 9 commits February 8, 2017 18:08
@foot
Fixes base font-size of popped out terminal.
047ce43 
Share the rest of the base styles too so the embedded and popped out
terminal are working from a common style base.
Stop using tag -f
14a555f 
(It's been removed from Docker)
@fbarl
Fixed the node stack display bug.
c8c6dd8
@foot
Merge pull request #2217 from weaveworks/2209-fixes-popped-out-termin…
ddd5a25 
…al-styles

Fixes base font-size of popped out terminal.
@fbarl
Merge pull request #2210 from weaveworks/fixed-node-stack-display
0bd24c5 
Fix for node stack display bug
@fbarl
Fix rounded square node shadow radius
df2193c
@fbarl
Merge pull request #2214 from weaveworks/fix-rounded-square-node-shad…
64fe756 
…ow-radius

Fix rounded square node shadow radius
Update CHANGELOG
3f41f45
Minor CHANGELOG update
7d5ef4b
@jpellizzari
Copy link
Contributor

LGTM!

@abuehrle
Copy link
Contributor

abuehrle commented Feb 8, 2017

scope stop with docker for mac: #2219

@ekimekim
Copy link
Contributor

ekimekim commented Feb 8, 2017

lgtm

1 similar comment
@davkal
Copy link
Contributor

davkal commented Feb 8, 2017

lgtm

Fix release shell script bug
8652828 
Introduced by 43d9f38 and found during release
@2opremio 2opremio merged commit 35182c8 into master Feb 8, 2017
@2opremio 2opremio deleted the release-1.2 branch February 8, 2017 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@2opremio @abuehrle @jpellizzari @ekimekim @davkal @foot @fbarl